[ros-kernel] ReactOS is not loading auto-start drivers anymore

[Mike Nordell]

Filip Navara wrote:

> VOID FASTCALL
> AcquireLoadDriverPrivilage(VOID)

Uhhh, OK. I'm sorry, but I just couldn't resist commenting on this. I found
it just too amusing. Fastcall calling conventions, for a function not taking
any parameters. :-)

But I'd like to add some stuff to the code:

>     /* Change our priority class to HIGH */
>     hProcess = OpenProcess(PROCESS_ALL_ACCESS, FALSE,
> GetCurrentProcessId());

Assert is your friend.
+   ASSERT(hProcess);

We have just recently seen problems with assumptions in gdi, in kmode, why I
wouldn't mind some more return value checking in this function. It is after
all vital to be able to start the system, why I feel all possible errors
should be checked and reported, and the "impossible" ones should be
asserted.


/Mike