[ros-kernel] winhlp32 runs on reactos
Thomas Weidenmueller
thomas at reactsoft.com
Mon Apr 26 22:24:23 CEST 2004
Howdy,
i just got winhlp32.exe from XP running inside reactos. I however needed
to patch msvcrt, cause it passes a NULL pointer in strstr(). I don't
know if it's a msvcrt bug or if winhlp32 just shouldn't pass this to
strstr() (due to some other problems maybe). The attached patch fixes it
though.
A couple of screenshots:
http://images.reactsoft.com/?img=.%2Fwinhlp32%2Fwinhlp1.png
http://images.reactsoft.com/?img=.%2Fwinhlp32%2Fwinhlp2.png
http://images.reactsoft.com/?img=.%2Fwinhlp32%2Fwinhlp3.png
http://images.reactsoft.com/?img=.%2Fwinhlp32%2Fwinhlp4.png
http://images.reactsoft.com/?img=.%2Fwinhlp32%2Fwinhlp5.png
http://images.reactsoft.com/?img=.%2Fwinhlp32%2Fwinhlp6.png
Regards
Thomas
-------------- next part --------------
Index: lib/msvcrt/string/strstr.c
===================================================================
RCS file: /CVS/ReactOS/reactos/lib/msvcrt/string/strstr.c,v
retrieving revision 1.4
diff -u -r1.4 strstr.c
--- lib/msvcrt/string/strstr.c 11 Jul 2003 21:58:09 -0000 1.4
+++ lib/msvcrt/string/strstr.c 26 Apr 2004 18:51:29 -0000
@@ -9,7 +9,10 @@
{
char c, sc;
size_t len;
-
+
+ if(!s || !find)
+ return 0;
+
if ((c = *find++) != 0)
{
len = strlen(find);
More information about the Ros-kernel
mailing list