[ros-kernel] RE: [ros-cvs] CVS Update: reactos

[Steven Edwards]

Hi Jens,
--- Jens Collin <jens.collin at lakhei.com> wrote:
> I made a small patch for shell32 in dialogs.c which I sent to the
> wine-devel list.
> I haven't received any response yet, but seeing this patch here in
> our
> CVS indicates that changes can be made in ROS only also? I thought
> all
> changes were to go into wine and then syncronized from time to time?
> 
> I like this approach below better since it makes changes get into our
> tree faster, but in the long term I beleive that syncronization will
> be
> tougher with all differences...
> Can anyone shed some light on this for me?

Some parts of shell32 will not be sync'd with Winehq. We used a icon
set the differs from the standard so that could be part of why Martin
committed it to the ReactOS tree. We DONT have a firm rule that says
DONT MAKE CHANGES IN A WINE DLL. It is up to each developer to make
sure that they send thier work to Winehq so as not to risk getting a
patch overwritten when we merge. You can go ahead and commit stuff to
shell32 if you need to but our ShellExecute is so out of sync that any
changes you commit to ReactOS are going to need to be totally redone
anyway when we merge.

Thanks
Steven



		
_______________________________
Do you Yahoo!?
Express yourself with Y! Messenger! Free. Download now. 
http://messenger.yahoo.com