[ros-kernel] Explorer Build Error

[Hervé Poussineau]

Hi!

James Tabor a écrit :
> i386-mingw32-g++ -D__USE_W32API -DWIN32 -D_ROS_ -D_WIN32_IE=0x0600 
> -D_WIN32_WINNT=0x0501 -DUNICODE -fexceptions -Wall -I. 
> -I../../../include -I../../../w32api/include -pipe -march=i386 -D_M_IX86 
> -c dialogs/settings.cpp -o dialogs/settings.o
> dialogs/settings.cpp: In member function `virtual int
>    TaskbarSettingsDlg::Command(int, int)':
> dialogs/settings.cpp:195: error: syntax error before `,' token
> dialogs/settings.cpp:201: error: syntax error before `,' token
> make[1]: *** [dialogs/settings.o] Error 1
> make[1]: Leaving directory `/home/ros/reactos/subsys/system/explorer'
> make: *** [explorer] Error 2

GCC 3.3.1 doesn't seem to accept following construction : 
ObjectType(Parameters).Method();

Try to apply following patch.

Herve
-------------- next part --------------
Index: subsys/system/explorer/taskbar/traynotify.cpp
===================================================================
RCS file: /CVS/ReactOS/reactos/subsys/system/explorer/taskbar/traynotify.cpp,v
retrieving revision 1.62
diff -u -r1.62 traynotify.cpp
--- subsys/system/explorer/taskbar/traynotify.cpp	2 Aug 2004 19:16:18 -0000	1.62
+++ subsys/system/explorer/taskbar/traynotify.cpp	3 Aug 2004 22:30:15 -0000
@@ -262,7 +262,8 @@
 	XMLPos pos = g_Globals.get_cfg();
 
 	pos.smart_create("desktopbar");
-	XMLBoolRef(XMLPos(pos,"options"), "show-clock") = _hwndClock!=0;
+	XMLBoolRef boolRef(XMLPos(pos,"options"), "show-clock");
+	boolRef = _hwndClock!=0;
 	pos.back();
 
 	pos.smart_create("notify-icons");

Index: subsys/system/explorer/dialogs/settings.cpp
===================================================================
RCS file: /CVS/ReactOS/reactos/subsys/system/explorer/dialogs/settings.cpp,v
retrieving revision 1.10
diff -u -r1.10 settings.cpp
--- subsys/system/explorer/dialogs/settings.cpp	2 Aug 2004 19:16:18 -0000	1.10
+++ subsys/system/explorer/dialogs/settings.cpp	3 Aug 2004 22:30:42 -0000
@@ -192,16 +192,22 @@
 		break;
 
 	  case ID_SHOW_CLOCK:
-		XMLBoolRef(XMLPos(g_Globals.get_cfg("desktopbar"),"options"), "show-clock", true).toggle();
+     {
+		XMLBoolRef boolRef1(XMLPos(g_Globals.get_cfg("desktopbar"),"options"), "show-clock", true);
+		boolRef1.toggle();
 		SendMessage(g_Globals._hwndDesktopBar, PM_REFRESH_CONFIG, 0, 0);
 		PropSheet_Changed(GetParent(_hwnd), _hwnd);
 		break;
+     }
 
 	  case ID_HIDE_INACTIVE_ICONS:
-		XMLBoolRef(XMLPos(g_Globals.get_cfg("notify-icons"),"options"), "hide-inactive", true).toggle();
+     {
+		XMLBoolRef boolRef2(XMLPos(g_Globals.get_cfg("notify-icons"),"options"), "hide-inactive", true);
+		boolRef2.toggle();
 		SendMessage(g_Globals._hwndDesktopBar, PM_REFRESH_CONFIG, 0, 0);
 		PropSheet_Changed(GetParent(_hwnd), _hwnd);
 		break;
+     }
 
 	  default:
 		return 1;