[ros-kernel] Coding style/indentation (again!?)

[Mike Nordell]

Waldo Alvarez Cañizares wrote:

> Well I think that even worse than that is the sources been filled with
things like :
>
> #ifdef (__GNU_C__)
>
> #else
>  junkneeded
> #endif

Due to your quoting style I couldn't really say what "that" referred to, but
I can say that your comment would be more correct like:

#ifdef (__GNU_C__)
  vendor proprietary language extensions used
#else
  plain C code
#endif

As such, are you really arguing in favor of vendor-lockin proprietary
extensions to the language at hand, instead of compiler-portable language
legal constructions?

> Sometimes to fix the lack of LONGLONG in other compilers.

This has nothing to do with LONGLONG, which all Win32 compilers handles
through different language extensions - MS-style __int64 or GCC/C99-style
"long long" (where I might add that MS have explicitly stated they have no
intentione of ever supporting C99, making this a GCC-only extention in
practice).

It instead has all to do with compiler-proprietary language extensions used,
incompatible definition of LARGE_INTEGER, PHYSICAL_ADDRESS for some reason
being a (U)LARGE_INTEGER instead of a LONGLONG, arithemetic operations on
void pointers and such.

> Isn't better to define LONLONG or LARGEINT?

Would you care to elaborate? Id' expect almost no code to ever be compilable
if they weren't.

> I would have saved myself tons of lines. It seems to be done with
> rush to support other compilers. What's the rush guys?

Ehhh, no. I did it to display I didn't change the code for GCC compilations,
while using language legal code for other compilers.


Btw, would you please stop attaching with every post that winmail.dat?
Thanks.


/Mike
[I snipped the following from a NG post, I can take no credit for it]

Here's some interesting reading for you:

how do I quote correctly in usenet?
http://www.netmeister.org/news/learn2quote2.html
the advantages of usenet's quoting conventions
http://homepage.ntlworld.com/g.mccaughan/g/remarks/uquote.html
why bottom-posting is better than top-posting
http://www.caliburn.nl/topposting.html
Bottom vs. top posting and quotation style on Usenet
http://www.cs.tut.fi/~jkorpela/usenet/brox.html
What do you mean "my reply is upside-down"?
http://www.i-hate-computers.demon.co.uk/