[ros-kernel] Re: ReactOS feedback - 0.20RC1a ISO

[Martin Fuchs]

> > thanks for the fixes. RC2 is a lot better to install this way.
> > still the Explorer error when hitting the "Printer" item in start menu 
> > is a problematic issue. ("Access denied")
> 
> This error comes out of from SHCoCreateInstance() in shell32 and
> only says, there is no implementation of the printer folder.
> So nothing surprising.
> 
> However I agree with you: This error message doesn't look
> very good for some user, who is confronted wih it without
> knowing where it comes from.

After thinking a bit about it, I would say let's disable this function
for the 0.2 release:


Index: startmenu.cpp
===================================================================
RCS file: /CVS/ReactOS/reactos/subsys/system/explorer/taskbar/startmenu.cpp,v
retrieving revision 1.67.2.1
diff -u -p -d -r1.67.2.1 startmenu.cpp
--- startmenu.cpp	19 Jan 2004 20:00:09 -0000	1.67.2.1
+++ startmenu.cpp	22 Jan 2004 23:51:49 -0000
@@ -1597,7 +1597,11 @@ int StartMenuHandler::Command(int id, in
 		break;
 
 	  case IDC_PRINTERS:
+#ifdef _ROS_
+		MessageBox(0, TEXT("printer folder not yet implemented in SHELL32"), ResString(IDS_TITLE), MB_OK);
+#else
 		CreateSubmenu(id, CSIDL_PRINTERS, CSIDL_PRINTHOOD, ResString(IDS_PRINTERS));
+#endif
 		break;
 
 	  case IDC_CONTROL_PANEL:
@@ -1728,7 +1732,11 @@ void SettingsMenu::AddEntries()
 #endif
 		AddButton(ResString(IDS_CONTROL_PANEL),	ICID_CONFIG, false, IDC_CONTROL_PANEL);
 
+#ifdef _ROS_
+	AddButton(ResString(IDS_PRINTERS),		ICID_PRINTER, false, IDC_PRINTERS);
+#else
 	AddButton(ResString(IDS_PRINTERS),		ICID_PRINTER, true, IDC_PRINTERS);
+#endif
 	AddButton(ResString(IDS_CONNECTIONS),	ICID_NETWORK, true, IDC_CONNECTIONS);
 	AddButton(ResString(IDS_ADMIN),			ICID_CONFIG, true, IDC_ADMIN);
 

Ge - do you agree we should commit this change although we are already in code freeze?


Regards,

   Martin