[ros-kernel] RE: [ros-cvs] CVS Update: reactos

[Filip Navara]

Hartmut Birr wrote:

>Hi,
>
>I think some of the changes are not correct:
>  
>
[snip]

>In both calls to DeviceIoControl, the datas are send to the device. This
>means we must use the input buffer and not the output buffer. Input and
>output is the meaning for the device and not for the caller.
>  
>
True, the data are sent to the device, but in METHOD_IN_DIRECT type of 
calls the input data buffer is stored in the output data buffer and 
vice-versa. Yes, it's confusing and so I don't wonder that it was 
implemented incorrectly. The DDK IoCtl sample and the doc/notes document 
in the ReactOS tree confirms that. It's handled mostly identically as 
METHOD_OUT_DIRECT except that the Mdl buffer is created for read access 
and not write access.

Regards,
Filip