[ros-kernel] Differences between ntdll and ntoskrnl Rtl functions

[Aleksey Bragin]

Your example isn't really a sharing example, it's a good example of forced
sharing, which nobody proposes here.
As Gunnar said he's not going to share routines which differ between
ntoskrnl and ntdll.

Might be in some cases when it's 

void func(params)
{
	// really a lot lines of code here

	if (serving_master_one)
	{
		// do it this way, contains 2-3 lines of code
	}
	else if (serving_master_two)
	{
		// do it that way, contains 2-3 lines of code
	}

	// even more code located here	
}

Then it is good, why not?

WBR,
Aleksey Bragin.

-----Original Message-----
From: ros-kernel-bounces at reactos.com [mailto:ros-kernel-bounces at reactos.com]
On Behalf Of Rick Parrish
Sent: Friday, June 04, 2004 7:48 AM
To: ReactOS Kernel List
Subject: Re: [ros-kernel] Differences between ntdll and ntoskrnl Rtl
functions

Waldo Alvarez Cañizares wrote:

>Sure. You can't . Sharing source code makes maintenance easier. 
>
Understood - usually - but not always. Having one body of source code 
serve the needs of two very different masters can lead to fractured 
coding. Something like ...

if (serving_master_one)
{
  // do it this way.
}
else if (serving_master_two)
{
  // do it that way.
}

At some point you're better off splitting code into two separate pieces.

-rick