Home | Info | Community | Development | myReactOS

Navigation
  1. Home
  2. Info
  3. Community
  4. Development
  5. myReactOS

Bugzilla
  1. Main Page
  2. New
  3. Search
  4. Reports
  5. Requests

Account
  1. Login
  2. Register

ReactOS bug tracking and reporting - Bug 2569 – msgina fails to start taskmgr

First Last Prev Next    No search results available
Details
: msgina fails to start taskmgr
Bug#: 2569
:
: ReactOS
: Patches
Status: RESOLVED
Resolution: FIXED
: x86 Hardware
: ReactOS
: unspecified
: P3
: minor
: ---
:
:
:
  Show dependency tree - Show dependency graph
People
Reporter: Heis Spiter <pierre.schweitzer@reactos.org>
Assigned To: hpoussin <hpoussin@reactos.org>
: Bug Zilla <ros-bugs@reactos.org>
:

Attachments
Patch file (3.50 KB, patch)
2007-08-13 13:18 CET, Heis Spiter 		Details
Patch file (new) (1.70 KB, patch)
2007-10-14 13:33 CET, Heis Spiter 		Details
Hide Obsolete (1) | View All Add an attachment (proposed patch, testcase, etc.)


Note

You need to log in before you can comment on or make changes to this bug.

Related actions

Description:   Opened: 2007-08-13 13:18 CET 
Created an attachment (id=1797) [details]
Patch file

This patch fixes one mistake in french translation and convert file from UTF-8
to ISO, to avoid bad string display in ROS. This patch also adds the
possibility to launch taskmgr when pressing Ctrl+Alt+Suppr, and pushing the
good button ;).
------- Comment #1 From usurp 2007-08-17 10:54:12 CET ------- 
seems to be fixed now.
taskmgr seems to be started but doesnt complete, or is this debug output
unrelated ?

(dll/win32/advapi32/sec/lsa.c:357) LsaOpenPolicy - stub
------- Comment #2 From hpoussin 2007-08-19 22:32:52 CET ------- 
The patch in bug description is wrong. Don't commit it.
------- Comment #3 From hpoussin 2007-08-28 16:40:04 CET ------- 
- Translation fix committed.

- Part to lauch taskmgr has been ignored, because it is wrong.
As expected, code execution goes up to StartTaskManager function (in 
winlogon/sas.c), which then fails. This needs to be investigated.
Bug has been renamed to reflect current state.
------- Comment #4 From Heis Spiter 2007-08-28 18:14:26 CET ------- 
After some investigations, it appears that's the CreateProcessAsUserW function
(around line 223) in WlxStartApplication function that fails. It fails with
status 1375 (ERROR_TOKEN_ALREADY_IN_USE). Everything before has been tested and
works.
------- Comment #5 From gabrielilardi 2007-09-26 16:58:51 CET ------- 
*** Bug 2454 has been marked as a duplicate of this bug. ***
------- Comment #6 From Heis Spiter 2007-10-14 13:33:18 CET ------- 
Created an attachment (id=2013) [details]
Patch file (new)

Here is a patch to fix WlxStartApplication.
According to http://support.microsoft.com/kb/889251/ and
http://www.mcse.ms/message659769.html we should duplicate token before trying
to start an application.
This patch presents two ways of duplicating the token. One (the #if 0) is (for
me) the best way to duplicate the token, but it doesn't work well (perhaps I
forgot something). The second one works perfectly, and we get taskmgr working
(whatever is the shortcut used).
There's an important if condition that shouldn't be removed because that's used
during ReactOS boot.
Of course, token is closed after use.

Be carefull, msgina debug is activated.
------- Comment #7 From hpoussin 2007-10-24 09:47:38 CET ------- 
Fixed in r29845
http://www.reactos.org/archives/public/ros-diffs/2007-October/019536.html
First Last Prev Next    No search results available