ReactOS bug tracking and reporting - Bug 4385 – PATCH: NtCurrentTeb()->glTable pointer is corrupted when using vboxogl.dll

Created an attachment (id=3837) [details]
patch

When using VirtualBox OpenGL ICD (vboxogl.dll), NtCurrentTeb()->glTable ends up
corrupted.  Events happen as follows:

- opengl32.dll is loaded
- OPENGL32_ThreadAttach() is run, allocating and initializing
NtCurrentTeb()->glTable
- rosglCreateLayerContext() is called by user (in my test, wined3d)
- icd->DrvCreateLayerContext() from vboxogl.dll is called.  After return,
NtCurrentTeb()->glTable points somewhere else, resulting in segfault or memory
corruption.

This problem doesn't happen with MS opengl32.dll.  I suspect the ICD is
starting new threads, and the allocation/initialization that is done in
OPENGL32_ThreadAttach should happen when a context is created instead.  I
managed to work around the problem with the attached patch.

Another oddity factor is that wined3d creates a context more than once during
initialization, which is unusual AFAIK.

Note1: My tests are with latest wined3d (1.1.19).  See
http://www.nongnu.org/wined3d/ for win32 builds.
Note2: see also bug 4384

Hi,
wined3d creates one fake opengl context which is released later.

And it would be ultra-nice from you to use our version of wined3d so we all
work with the same code.

(In reply to comment #1)
> Hi,
> wined3d creates one fake opengl context which is released later.

Yeah, do you think this could be related to the problem?

> And it would be ultra-nice from you to use our version of wined3d so we all
> work with the same code.

Well, I'm doing the tests on XP, and using wined3d 1.1.19 which includes recent
fixes related to VBox.  I'm not sure which version of wined3d is in your tree,
but I strongly advice to upgrade if it's older than 1.1.19.  This was the first
release that worked on a MS-opengl32.dll/VBoxOGL.dll/XP stack without patching
(my current interest in ReactOS is replacing MS opengl32.dll).

(In reply to comment #2)
> 
> Well, I'm doing the tests on XP, and using wined3d 1.1.19 which includes recent
> fixes related to VBox.  I'm not sure which version of wined3d is in your tree,
> but I strongly advice to upgrade if it's older than 1.1.19.  
>

Sync was done recently on r40534. Are you planning to submit a patch to Wine as
well btw? 

(In reply to comment #3)
> Are you planning to submit a patch to Wine as
> well btw? 

My patch is for opengl32.dll, not Wine!  And it's a workaround anyway, it's not
meant to be merged anywhere...

(In reply to comment #4)
> My patch is for opengl32.dll, not Wine!  And it's a workaround anyway, it's not
> meant to be merged anywhere...
> 

okay, disregard my earlier comment, i'm not clear as to what's going on..

This might (or might not) be related to this problem:

http://www.virtualbox.org/ticket/3762
http://www.virtualbox.org/changeset/19099

Note that the problem was found using the 2.1 version of VirtualBox Guest
Additions

please reconfirm this. it seems to be fixed in virtualbox now.

Consulted myself with Kamil, closing as the bug was in vbox ogl driver, and the
patch is a hack.