Home | Info | Community | Development | myReactOS

Navigation
  1. Home
  2. Info
  3. Community
  4. Development
  5. myReactOS

Bugzilla
  1. Main Page
  2. New
  3. Search
  4. Reports
  5. Requests

Account
  1. Login
  2. Register

ReactOS bug tracking and reporting - Bug 4820 – PATCH - SetDllDirectory does not influence on LoadLibrary

First Last Prev Next    No search results available
Details
: PATCH - SetDllDirectory does not influence on LoadLibrary
Bug#: 4820
:
: ReactOS
: Win32
Status: RESOLVED
Resolution: FIXED
: QEmu
: ReactOS
: TRUNK
: P3
: major
: ---
: http://msdn.microsoft.com/en-us/library/ms686203(VS.85).aspx
:
:
  Show dependency tree - Show dependency graph
People
Reporter: none <menone7@gmail.com>
Assigned To: Lentin <lentind@yandex.ru>
: Bug Zilla <ros-bugs@reactos.org>
:

Attachments
add this functional to GetDllLoadPath (858 bytes, patch)
2009-08-28 09:19 CET, none 		Details | Diff
Remove null term (435 bytes, patch)
2009-10-11 10:28 CET, _Russell_ 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)


Note

You need to log in before you can comment on or make changes to this bug.

Related actions

Description:   Opened: 2009-08-28 09:19 CET 
Created an attachment (id=4268) [details]
add this functional to GetDllLoadPath

SetDllDirectory must adds a directory to the search path used to locate DLLs
for the application.
LoadLibrary does not search library on the specified path
LoadLybraryExW called function GetDllLoadPath for get paths
------- Comment #1 From fireball 2009-10-10 11:16:45 CET ------- 
Committed in r43357.
------- Comment #2 From _Russell_ 2009-10-10 15:22:11 CET ------- 
Bug reopened as the patch causes the device installation dialog to not work
correctly.

From what I can tell, line 96 is the cause of the bug, it doesn't increment
before setting EnvironmentBufferW[Pos] = 0;

In order to fix this, a change may have to be made on line 72 to include a NULL
termination character in RtlAllocateHeap and a change to line 96, but I don't
know enough about wchar/unicode to include a patch
------- Comment #3 From _Russell_ 2009-10-11 10:28:34 CET ------- 
Created an attachment (id=4320) [details]
Remove null term

Actually, it can just be removed with this patch (attached), since
GetEnvironmentVariableW null terminates anyway
------- Comment #4 From fireball 2009-10-12 21:45:31 CET ------- 
Committed in r43416.
First Last Prev Next    No search results available