[ros-bugs] [Bug 1095] New: Incorrect variable could cause buffer overflow

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=1095

           Summary: Incorrect variable could cause buffer overflow
           Product: ReactOS
           Version: TRUNK
          Platform: x86 Hardware
        OS/Version: ReactOS
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Win32
        AssignedTo: ros-bugs at reactos.org
        ReportedBy: mbealby at gmail.com
         QAContact: ros-bugs at reactos.org


File: reactos/lib/kernel32/debug/output.c
Func: OutputDebugStringA
Line: 400 and 403 (subversion revision 19963)

When checking for a buffer overflow condition nRoundLen is modified. However, in
the memcpy and null-termination code nOutputStringLen is used. Contrast this to
the case of sending to the kernel debugger (lines 414-424) when nRoundLen is used.

I think this is just a simple mistake of using the wrong variable.

-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the QA contact for the bug, or are watching the QA contact.