[ros-bugs] [Bug 1103] New: No return value checking (2)

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=1103

           Summary: No return value checking (2)
           Product: ReactOS
           Version: TRUNK
          Platform: x86 Hardware
        OS/Version: ReactOS
            Status: NEW
          Severity: normal
          Priority: P3
         Component: Win32
        AssignedTo: ros-bugs at reactos.org
        ReportedBy: mbealby at gmail.com
         QAContact: ros-bugs at reactos.org


File: reactos/lib/kernel32/misc/errormsg.c
Func: FormatMessageA
Line: 179 (svn revision 19963)

The return value from HeapAlloc is not checked. If it fails null is
returned (no exceptions generated) and the strcpy function will seg-fault.

--- Broken code start ---
from = HeapAlloc( GetProcessHeap(), 0, strlen((LPCSTR)lpSource)+1 );
strcpy( from, (LPCSTR)lpSource );
--- Broken code end ---

-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the QA contact for the bug, or are watching the QA contact.