[ros-bugs] [Bug 805] Shutdown issues

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=805





------- Additional Comments From gvg at reactos.org  2005-10-16 00:14 CET -------
Created an attachment (id=404)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=404&action=view)
Proposed patch

Ok, how about the attached patch?
The cause of the problem is that at some point the CSRSS thread which created
the desktop window is terminated. That means all the windows created by that
thread (i.e. the desktop window itself) will be destroyed. There is a check in
line 2036 which checks if the window to be destroyed is a desktop window and,
if so, it will deny the request to destroy the window. Since the window remains
in the threads window list, this will cause the endless loop which has been
observed.
However, the check to see if this is a desktop window is redundant. The desktop
is created by a CSRSS thread and the thread check in the same statement makes
sure that only that same CSRSS thread can destroy it (i.e. a normal user
process will still not be able to destroy the desktop). Of course, destroying
the desktop will also mean all its children (all other windows) are destroyed,
but that seems the most reasonable thing to do anyway, certainly at this point
(during shutdown).

-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the QA contact for the bug, or are watching the QA contact.