[ros-bugs] [Bug 931] Make cross-build on FreeBSD functional

ReactOS.Bugzilla at reactos.org ReactOS.Bugzilla at reactos.org
Wed Oct 26 19:43:02 CEST 2005


http://www.reactos.org/bugzilla/show_bug.cgi?id=931





------- Additional Comments From gvg at reactos.org  2005-10-26 19:43 CET -------
A few questions about the patch:
1) I'm a bit surprised that you're testing the __FreeBSD__ version. Shouldn't
you use the GCC version instead (if that's testable, don't know).
2) Don't pshpack1.h, pshpack4.h and pshpack8.h need the same changes as pshpack2.h?
3) Can't w32api/include/wingdi.h use the pshpack*.h and poppack.h include files
instead of using the #pragma's directly? I know they were not using the include
files before your patch, but perhaps we can clean it up in one go.

-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the QA contact for the bug, or are watching the QA contact.


More information about the Ros-bugs mailing list