[ros-bugs] [Bug 735] Last page of the second stage installer looks like crap.

ReactOS.Bugzilla at www.reactos.org ReactOS.Bugzilla at www.reactos.org
Thu Jun 21 03:49:18 CEST 2007


http://www.reactos.org/bugzilla/show_bug.cgi?id=735


timo.kreuzer at web.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




------- Comment #8 from timo.kreuzer at web.de  2007-06-21 03:49 CET -------
I reopen this bug, because it was not properly fixed. It was instead hackfixed,
introducing bug 902, wich is probably worse than this one.

The problem is that the propsheet control is not properly redrawn, when the
page changes. It was introduced by a wine sync of comctl32, removing an
InvalidateRgn(). Readding this line will "fix" the bug, but it is not a problem
of comctl32, as it works with wine's comctl32.dll in windows xp.

The propsheet window recieves a WM_PAINT message when the page changes. At this
point psInfo->active_page has the correct value (the new page, wich is strange,
because the new page gets set after the old page is removed and the new page is
shown). The update region does not include all the space that should be
redrawn. It only redraws those parts that got invalid, when the last page was
removed, but the pages only cover a part of the propsheet and they cover
different parts depending of the style of the page. Some pages don't show any
problem, because of the watermark being redrawn and because the pages
themselves are bigger than the first and last page in our syssetup.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.


More information about the Ros-bugs mailing list