[ros-bugs] [Bug 2248] cmd history with right key
ReactOS.Bugzilla at www.reactos.org
ReactOS.Bugzilla at www.reactos.org
Sat May 12 23:46:50 CEST 2007
http://www.reactos.org/bugzilla/show_bug.cgi?id=2248
------- Comment #2 from hpoussin at reactos.org 2007-05-12 23:46 CET -------
This patch is not correct
1) It is limited to command lines of MAX_PATH chars, and hence, can provide a
buffer overflow
2) It copies a command from the history to a new buffer, only to display one
char. That's probably better to directly peek the char in the history buffer
3) It breaks indentation
--
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.
You are the assignee for the bug, or are watching the assignee.
More information about the Ros-bugs
mailing list