[ros-bugs] [Bug 3342] MSI based installs fail when in dir names with space

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=3342


grschneider <grschneider at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |grschneider at gmail.com




--- Comment #2 from grschneider <grschneider at gmail.com>  2008-08-22 21:29:35 CET ---
Tried python 2.5.2 install, the installer startup takes the following route:

(...) -> SHELL_execute (shell32) -> execute_from_key (shell32) ->
SHELL_ExecuteW (shell32) -> CreateProcessW (kernel32) -> (...) -> main
(msiexec) -> MsiInstallProductW (msi) -> MSI_OpenPackageW (msi) ->
copy_package_to_temp (msi)

The command string shell32 assembles is:
C:\\ReactOS\\system32\\msiexec /i C:\\python python python\\python-2.5.2.msi

Kernel32 CreateProcessWInternal looks for quotes first - if none looks for
white spaces as separators. I think shell32/SHELL_execute should assemble the
command like this:
"C:\\ReactOS\\system32\\msiexec" /i "C:\\python python
python\\python-2.5.2.msi"

like it is done for another var (wszQuotedCmd) starting at line 1613.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.