[ros-bugs] [Bug 2947] Patch for msvcrt20

ReactOS.Bugzilla at www.reactos.org ReactOS.Bugzilla at www.reactos.org
Thu Jan 10 14:48:25 CET 2008


http://www.reactos.org/bugzilla/show_bug.cgi?id=2947


fireball <fireball at reactos.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fireball at reactos.com
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID




--- Comment #1 from fireball <fireball at reactos.com>  2008-01-10 14:48:24 CET ---
There is a problem using .spec files for msvcrt and msvcrt20.dll. I had to
revert my .spec changes and go back to updated .def file in msvcrt.dll, because
of the following problem: stdcall functions exported by msvcrt(20).dll are not
decorated with the "@X" (where X is the number of parameters bytes).

Take msvcrt20.dll from trunk, and take msvcrt20.dll done with your patch, and
run dependency walker, or any other tool which shows DLL exports. You'll see
most of them match, except for those marked as stdcall. Example:
_adj_fdiv_m16i (correct export name for msvcrt) vs. _adj_fdiv_m16i at 4
(incorrect, because @4 is added to the name).

I suggest just regenerating .def file, and look how I did with msvcrt.dll about
adding stubs (autogenerated from the .spec file from Wine).

Reopen the bug when you're done.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the Ros-bugs mailing list