[ros-bugs] [Bug 3486] New: Bug in NtGdiExtTextOutW

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=3486

           Summary: Bug in NtGdiExtTextOutW
           Product: ReactOS
           Version: TRUNK
          Platform: x86 Hardware
        OS/Version: ReactOS
            Status: UNCONFIRMED
          Severity: major
          Priority: P3
         Component: Win32
        AssignedTo: ros-bugs at reactos.org
        ReportedBy: hto at dev.null
         QAContact: ros-bugs at reactos.org


Created an attachment (id=2780)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=2780)
Patch

// include/bitmaps.h
#define  BITMAPOBJ_UnlockBitmap(pBMObj)  \
  GDIOBJ_UnlockObjByPtr ((POBJ)pBMObj)

// objects/gdiobj.c
GDIOBJ_UnlockObjByPtr(POBJ Object)
{
  if (_InterlockedDecrement((PLONG)&Object->cExclusiveLock) < 0) // CRASH!!!
  ...
}

// objects/text.c
NtGdiExtTextOutW()
{
  ...
  BITMAPOBJ *BitmapObj = NULL;
  ...
  BitmapObj = BITMAPOBJ_LockBitmap(dc->w.hBitmap);
  if ( !BitmapObj )
  {
     goto fail;
  }
  ...
fail:
  ...
  BITMAPOBJ_UnlockBitmap(BitmapObj);
  ...
}


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.