[ros-bugs] [Bug 733] Starcraft installer changes the colors of everything else

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=733


amine48rz <amine48rz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
             Status|ASSIGNED                    |NEW

NetRolller 3D <netrolller.3d at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|trivial                     |major

ThePhysicist <timo.kreuzer at web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|major                       |trivial

NetRolller 3D <netrolller.3d at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|trivial                     |minor

amine48rz <amine48rz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amine48rz at gmail.com

grschneider <grschneider at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |grschneider at gmail.com
                 CC|                            |ericsbinaryworld at gmail.com
           Severity|minor                       |major

amine48rz <amine48rz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jimtabor at adsl-64-217-116-
                   |                            |74.dsl.hstntx.swbell.net




--- Comment #7 from NetRolller 3D <netrolller.3d at gmail.com>  2007-10-13 16:58:47 CET ---
Not trivial, because some programs change foreground and background to the same
color, rendering everything unreadable! Might even be exploitable for a DoS
attack!


--- Comment #8 from ThePhysicist <timo.kreuzer at web.de>  2007-10-14 14:09:58 CET ---
please check
http://www.reactos.org/bugzilla/page.cgi?id=fields.html#bug_severity
no crash, no loss in functionality, no patch, no regression
-> trivial


--- Comment #9 from NetRolller 3D <netrolller.3d at gmail.com>  2007-10-14 21:41:54 CET ---
There IS a heavy loss of functionality, as with the VMware Tools installer, the
colors change to identical foreground/background, so everything disappears, and
because you are essentially "blind" in such case, a hard reset (of the virtual
machine) is required. Not major though, I intended to set it to Minor.


--- Comment #10 from amine48rz <amine48rz at gmail.com>  2008-05-09 19:39:27 CET ---
I've tested it in r33384 under vmware workstation (16 and 32 bit) and qemu (16
and 24 bit). Screenshot is attached.


--- Comment #11 from amine48rz <amine48rz at gmail.com>  2008-05-09 19:40:38 CET ---
Created an attachment (id=2487)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=2487)
New screenshot


--- Comment #12 from grschneider <grschneider at gmail.com>  2008-06-30 20:03:29 CET ---
I did some research and it turns out, that this bug has the same problem as bug
bug #1320. See file subsystems\win32\win32k\objects\color,
IntGdiRealizePalette.
A critical palette change only happens, if the dc is a display DC and
palGDI->NumColors != sysGDI->NumColors. palGDI->NumColors is 256 for the
starcraft installer, 10 for solitaire, sysGDI->NumColors is 20 in both cases.
In those two cases DriverFunctions.SetPalette is set with a new palette AND a
XLATEOBJ is created for color conversion in step 3.

Either one of those two color conversions is obsolete I think. I removed the
DriverFunctions.SetPalette call for display DC's and after that solitaire and
starcraft installer looked normal again.


--- Comment #13 from grschneider <grschneider at gmail.com>  2008-06-30 20:04:35 CET ---
Created an attachment (id=2734)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=2734)
proposed patch


--- Comment #14 from grschneider <grschneider at gmail.com>  2008-06-30 20:05:49 CET ---
Created an attachment (id=2735)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=2735)
starcraft installer (german) after applying the patch


--- Comment #15 from grschneider <grschneider at gmail.com>  2008-06-30 20:06:06 CET ---
*** Bug 1320 has been marked as a duplicate of this bug. ***


--- Comment #16 from grschneider <grschneider at gmail.com>  2008-06-30 20:41:31 CET ---
This fixes bug #3236 8bpp mode problem too.
Changing severity to major for review by win32k devs.
Gregor Schneider, grschneider AT gmail DOT com


--- Comment #17 from grschneider <grschneider at gmail.com>  2008-07-09 21:02:08 CET ---
The code shown in comment #13 was commented out in 34228.
Bugs remains open because: jimtabor * If I'm not sure about it I leave it open.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.