[ros-bugs] [Bug 1255] mathematic display/computation and python compatibility

ReactOS.Bugzilla at www.reactos.org ReactOS.Bugzilla at www.reactos.org
Thu Jul 10 20:11:54 CEST 2008


http://www.reactos.org/bugzilla/show_bug.cgi?id=1255





--- Comment #15 from jeanmichel.123 <jeanmichel.123 at free.Fr>  2008-07-10 20:11:51 CET ---
Ordinal is not the issue.

I have the solution.
It seams easy to solve.

In current reactos, fmod works fine, when _CIfmod don't.


Reading python23.dll through objdump, I discovered that this pyhton dll does
not call fmod, but _CIfmod.

_CIfmod is an msvcrt function coded in ReactOS in some stub.c file.

I made a try, copying some code from 
http://source.winehq.org/source/dlls/msvcrt/math.c

#define FPU_DOUBLES(var1,var2) double var1,var2; \
   __asm__ __volatile__( "fstpl %0;fwait" : "=m" (var2) : ); \
   __asm__ __volatile__( "fstpl %0;fwait" : "=m" (var1) : )

double CDECL _CIfmod(void)
{
  FPU_DOUBLES(x,y);
  return fmod(x,y);
}
to stub.c.

This makes python 2.3.5 works better:

divmod(3.25, 1.0) makes (3.0, 0.25), now.

Now, test_builtin.py passes divmod test, but still crashes on pow.

Might be some _CIfmod does exist?


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the Ros-bugs mailing list