[ros-bugs] [Bug 3465] Opera 9.51 crashes at start

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=3465





--- Comment #3 from jimtabor <jimtabor at adsl-64-217-116-74.dsl.hstntx.swbell.net>  2008-07-26 01:10:11 CET ---
Patch by grschneider:
VLC hackhackhack (redzone overwrite- bug 821):

Index: bitmaps.c
===================================================================
--- bitmaps.c   (revision 34732)
+++ bitmaps.c   (working copy)
@@ -139,14 +139,7 @@
        if (pBmp->SurfObj.pvBits != NULL &&
                (pBmp->flFlags & BITMAPOBJ_IS_APIBITMAP))
        {
-               if (pBmp->dib == NULL)
-               {
-                       ExFreePool(pBmp->SurfObj.pvBits);
-               }
-               else
-               {
-                       EngFreeUserMem(pBmp->SurfObj.pvBits);
-               }
+        EngFreeUserMem(pBmp->SurfObj.pvBits);
                if (pBmp->hDIBPalette != NULL)
                {
                        NtGdiDeleteObject(pBmp->hDIBPalette);


Patch prevents Opera from crashing.
Leave open Bug


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.