[ros-bugs] [Bug 1255] msvcrt 's _CIfmod crashes python 2.3.5 and ReactOS

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=1255





--- Comment #20 from jeanmichel.123 <jeanmichel.123 at free.Fr>  2008-07-26 21:32:12 CET ---
(In reply to comment #18)
> (In reply to comment #16)
> > As for why python hangs when the test fails: This is caused by a bug in
> > lib\sdk\crt\mem\i386\memchr_asm.s. "repne scasb" doesn't affect ZF when ecx=0,
> > so memchr(..., ..., 0) will not always return NULL like it should. This puts
> > python's file_readlines into an infinite loop.
> > 
> > Putting something to clear ZF (e.g. "test %esp,%esp") before it will fix that
> > problem.
> > 
> 
> I am not so sure.
> I have modified the two crt rbuild files, to use c version of memchr, instead
> of i386 ones.
> 
> Bug is still here: python takes all memory, and then:

It looks like, on my computer, crash disappeared after some svn update and 
clean && make bootcd. Now test_pow is just marked as FAIL.

Might be due to the following modification?

Index: libcntpr.rbuild
===================================================================
--- libcntpr.rbuild     (révision 34807)
+++ libcntpr.rbuild     (copie de travail)
@@ -60,15 +60,16 @@
        </directory>

        <directory name="mem">
-               <if property="ARCH" value="i386">
+               <if property="ARCH" value="i386no">
+                       <file>memchr.c</file>
                        <directory name="i386">
-                               <file>memchr_asm.s</file>
+                               <!-- <file>memchr_asm.s</file> -->
                                <file>memcpy_asm.s</file>
                                <file>memmove_asm.s</file>
                                <file>memset_asm.s</file>
                        </directory>
                </if>
-               <ifnot property="ARCH" value="i386">
+               <ifnot property="ARCH" value="i386no">
                        <file>memchr.c</file>
                        <file>memcpy.c</file>
                        <file>memmove.c</file>
Index: crt.rbuild
===================================================================
--- crt.rbuild  (révision 34807)
+++ crt.rbuild  (copie de travail)
@@ -175,15 +175,16 @@
        </directory>

        <directory name="mem">
-               <if property="ARCH" value="i386">
+               <if property="ARCH" value="i386no">
+                       <file>memchr.c</file>
                        <directory name="i386">
-                               <file>memchr_asm.s</file>
+                               <!-- <file>memchr_asm.s</file> -->
                                <file>memcpy_asm.s</file>
                                <file>memmove_asm.s</file>
                                <file>memset_asm.s</file>
                        </directory>
                </if>
-               <ifnot property="ARCH" value="i386">
+               <ifnot property="ARCH" value="i386no">
                        <file>memchr.c</file>
                        <file>memcpy.c</file>
                        <file>memmove.c</file>


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.