[ros-bugs] [Bug 3598] New: telnet: include order may cause a bad redefinition of _pctype

ReactOS.Bugzilla at www.reactos.org ReactOS.Bugzilla at www.reactos.org
Mon Jul 28 00:19:28 CEST 2008


http://www.reactos.org/bugzilla/show_bug.cgi?id=3598

           Summary: telnet: include order may cause a bad redefinition of
                    _pctype
           Product: ReactOS
           Version: TRUNK
          Platform: QEmu
        OS/Version: ReactOS
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: Networking
        AssignedTo: ros-bugs at reactos.org
        ReportedBy: mslomp at linuxmail.org
         QAContact: ros-bugs at reactos.org
                CC: mslomp at linuxmail.org


target files:
base/applications/network/telnet/src/{tkeymap.cpp,tmapldr.cpp}

The declaration of internal includes after the standard c++ headers may cause a
redefinition of _pctype in some versions of GCC.
The patch below fixes this by just changing the order in which the headers
appear.

Marcelo A. B. Slomp 

Index: base/applications/network/telnet/src/tmapldr.cpp
===================================================================
--- base/applications/network/telnet/src/tmapldr.cpp    (revision 34860)
+++ base/applications/network/telnet/src/tmapldr.cpp    (working copy)
@@ -29,6 +29,10 @@
 //     originally part of KeyTrans.cpp                 //
 /////////////////////////////////////////////////////////

+#include "tmapldr.h"
+#include "tnerror.h"
+#include "tnconfig.h"
+
 #ifdef __BORLANDC__
 #include <fstream.h>
 #else
@@ -36,10 +40,6 @@
 #include <fstream>
 #endif

-#include "tmapldr.h"
-#include "tnerror.h"
-#include "tnconfig.h"
-
 // It's probably a good idea to turn off the "identifier was truncated"
warning
 // in MSVC (Paul Brannan 5/25/98)
 #ifdef _MSC_VER
Index: base/applications/network/telnet/src/tkeymap.h
===================================================================
--- base/applications/network/telnet/src/tkeymap.h      (revision 34860)
+++ base/applications/network/telnet/src/tkeymap.h      (working copy)
@@ -1,6 +1,8 @@
 #ifndef __TKEYMAP_H
 #define __TKEYMAP_H

+#include "tkeydef.h"
+
 #ifdef __BORLANDC__
 #include <classlib\arrays.h>
 #else
@@ -8,8 +10,6 @@
 #include "stl_bids.h"
 #endif

-#include "tkeydef.h"
-
 //AVS
 typedef TArrayAsVector<TKeyDef> keyArray;


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the Ros-bugs mailing list