[ros-bugs] [Bug 3599] New: explorer: redeclaration of _pctype from const to static

ReactOS.Bugzilla at www.reactos.org ReactOS.Bugzilla at www.reactos.org
Mon Jul 28 01:20:52 CEST 2008


http://www.reactos.org/bugzilla/show_bug.cgi?id=3599

           Summary: explorer: redeclaration of _pctype from const to static
           Product: ReactOS
           Version: TRUNK
          Platform: QEmu
        OS/Version: ReactOS
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: Shell
        AssignedTo: ros-bugs at reactos.org
        ReportedBy: mslomp at linuxmail.org
         QAContact: ros-bugs at reactos.org
                CC: mslomp at linuxmail.org


target file:
base/shell/explorer/utility/utility.h

like the reported in [3598], precompiling header for explorer may fail under
certain build environments (and in this case, specifically under non-win32
hosts), overriding the declaration of _pctype.
Below, the patch to fix this issue.

Marcelo A. B. Slomp

Index: base/shell/explorer/utility/utility.h
===================================================================
--- base/shell/explorer/utility/utility.h       (revision 34860)
+++ base/shell/explorer/utility/utility.h       (working copy)
@@ -25,6 +25,11 @@
  // Martin Fuchs, 23.07.2003
  //

+ // standard windows headers
+#define WIN32_LEAN_AND_MEAN
+#define WIN32_EXTRA_LEAN
+#include <windows.h>
+
 #ifdef __cplusplus

 #ifdef _MSC_VER
@@ -39,11 +44,6 @@
 #endif /* __cplusplus */


- // standard windows headers
-#define WIN32_LEAN_AND_MEAN
-#define WIN32_EXTRA_LEAN
-#include <windows.h>
-
  // Unicode support
 #if defined(UNICODE) && !defined(_UNICODE)
 #define        _UNICODE


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the Ros-bugs mailing list