[ros-bugs] [Bug 3332] New: About WINE debug code.

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=3332

           Summary: About WINE debug code.
           Product: ReactOS
           Version: TRUNK
          Platform: QEmu
        OS/Version: ReactOS
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: Patches
        AssignedTo: ros-bugs at reactos.org
        ReportedBy: carlo.bramix at libero.it
         QAContact: ros-bugs at reactos.org


Created an attachment (id=2604)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=2604)
Fix for this bug

Here I attached a suggestion for disabling the WINE code for trace and debug.
Description of changes:

ReactOS-generic.rbuild
If DBG support is zero, then there is no need of WINE debug stuff (there is no
way to output those messages, so I disabled them here).
It also possible to make them in a different place, if you prefer a different
solution.

dll/win32/advapi32/sec/sid.c
lib/sdk/crt/except/cppexcept.c
Into these files there are some static functions that are unused if WINE debug
stuff is disabled.
Since the warnings are interpreted as errors with these sources, I had to do an
#ifdef...#endif for solving the issue.

=================================

Results after applying the patch:
ReactOS with DBG=1: memory usage = 96 MB
ReactOS with DBG=0 with WINE debugs: memory usage = 92 MB
ReactOS with DBG=0 without WINE debugs: memory usage = 88 MB

Values obtained with the task manager and without running programmes expect the
ReactOS itself.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.