[ros-bugs] [Bug 3370] New: Reactos trunk fails to compile, at least with GCC 4.3.1 as a host compiler.

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=3370

           Summary: Reactos trunk fails to compile, at least with GCC 4.3.1
                    as a host compiler.
           Product: ReactOS
           Version: TRUNK
          Platform: QEmu
        OS/Version: ReactOS
            Status: UNCONFIRMED
          Severity: blocker
          Priority: P3
         Component: Patches
        AssignedTo: ros-bugs at reactos.org
        ReportedBy: deathplanter at gmail.com
         QAContact: ros-bugs at reactos.org


Created an attachment (id=2650)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=2650)
A patch fixing the build errors.

Hi guys,

I've just tried compiling SVN trunk of the ReactOS on Linux and noticed two
weird errrors:

1. tools/cabman/dfp.cxx fails to compile unless -Werror is removed:

deathplanter at deathplanter-PC:~/reactos$ make
[CC]      tools/cabman/dfp.cxx
cc1plus: warnings being treated as errors
tools/cabman/dfp.cxx: In member function ?void CDFParser::NextToken()?:
tools/cabman/dfp.cxx:1378: error: suggest parentheses around && within ||
make: *** [obj-i386/tools/cabman/dfp_cabman.o] Error 1

The code is:

            while ((CurrentChar + i < LineLength) &&
                (((ch = Line[CurrentChar + i]) >= 'a') && (ch <= 'z')) ||
                ((ch >= 'A') && (ch <= 'Z')) || (ch == '_'))
            {

2. there are lacking header files in the #include part of
tools/sysreg/pipe_reader.h

I really have no idea why #include <stdlib.h> was commented out. There was also
#include <cstring> needed for memset() and #include <limits.h> for INT_MAX
declaration. I guess the patch needs some just-in-case testing on Windows.

I've attached a walkaround patch to the bug report.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.