[ros-bugs] [Bug 3353] wprintf output is garbled
ReactOS.Bugzilla at www.reactos.org
ReactOS.Bugzilla at www.reactos.org
Sat Jun 21 12:21:08 CEST 2008
http://www.reactos.org/bugzilla/show_bug.cgi?id=3353
--- Comment #6 from Colin Finck <mail at colinfinck.de> 2008-06-21 12:21:07 CET ---
Looking at the current string stuff in crt, I wonder if just importing *all* of
msvcrt from Wine was really a good idea.
Previously, we didn't have that mess with lnx_ and normal string functions
including a lot more function redefines to get this all to build.
Also our msvcrt was developed independently of the Wine version and looking at
some functions like putwc (where this Unicode -> ANSI conversion took place in
the old code), our code also seems to be superior in many cases.
So effectively, I would propose reimporting our old string code into crt and
fixing the last outstanding bugs to pass the "printf" Wine tests ourselves.
If you really want to stay with the current code, there is something else I
noticed: You changed vsnprintf to _vsnprintf in r34026, but internally many
functions still call vsnprintf.
--
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the Ros-bugs
mailing list