[ros-bugs] [Bug 3747] A basic _kbhit() implementation

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=3747


Lone_Rifle <alwyn.tan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alwyn.tan at gmail.com




--- Comment #2 from Lone_Rifle <alwyn.tan at gmail.com>  2008-11-28 11:02:16 CET ---
(In reply to comment #1)
> Two comments concerning this patch:
> 
> The variable "volatile BOOL CriticalSectionInitialized" is used uninitialised
> and never set, is there any reason for using it?
> 
> The check 
> if (InputRecord[RecordIndex].EventType == KEY_EVENT &&  
> (InputRecord[RecordIndex].Event.KeyEvent.bKeyDown ||
> !InputRecord[RecordIndex].Event.KeyEvent.bKeyDown)) 
> either contains a typo or contains useless parts since it basically says (a &&
> (b || !b)) which is equal to just (a).
> 

[09:57] <+Russell> its a typo

Russell no longer has the time to work on this.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.