[ros-bugs] [Bug 3889] Host header included in Ntoskrnl

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=3889


Colin Finck <mail at colinfinck.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |INVALID




--- Comment #3 from Colin Finck <mail at colinfinck.de>  2008-11-28 21:41:42 CET ---
(In reply to comment #2)
> I do not agree -- these utf16_* nowhere needed in ntoskrnl.

They are used inside cmlib to make it working properly under host and target.
This is required because the wchar_t length is not 2 bytes on all hosts.
Therefore we reimplement these string functions especially for 2 byte
wchar_t's.

You might think, we should rather redefine the wcs* functions to the utf16_wcs*
functions for host modules and leave them alone if we're building for target,
but this fails as a redefinition of any compiler-internal function requires the
prototypes to match exactly (which is of course not possible with a different
wchar_t length).

So this is the only way to do it kinda properly in my opinion.
And due to the redefinition for target modules, it doesn't cause any overhead
there.

If you have an alternative idea to solve this problem, please tell me here, but
for now I'll close this bug as INVALID again.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.