[ros-bugs] [Bug 3925] New: Inconsistency in PSDK headers

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=3925

           Summary: Inconsistency in PSDK headers
           Product: ReactOS
           Version: TRUNK
          Platform: x86 Hardware
        OS/Version: ReactOS
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: Patches
        AssignedTo: ros-bugs at reactos.org
        ReportedBy: hto at dev.null
         QAContact: ros-bugs at reactos.org


Created an attachment (id=3300)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=3300)
Patch

In psdk/prsht.h, PSN_* constants defined as negative values:
#define PSN_FIRST       (-200)
...

But psdk/winuser.h defines 'code' field of NMHDR structure as unsigned:

typedef struct tagNMHDR {
        HWND hwndFrom;
        UINT idFrom;
        UINT code;
} NMHDR,*LPNMHDR;

(NMHDR is used in PSHNOTIFY structure from psdk/prsht.h).

typedef struct _PSHNOTIFY {
        NMHDR hdr;
        LPARAM lParam;
} PSHNOTIFY,*LPPSHNOTIFY;

It causes compiler warnings/errors: "error: comparison between signed and
unsigned integer expressions".


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.