[ros-bugs] [Bug 4342] log2lines: Enhanced raddr2line replacement

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=4342


hto <hto at dev.null> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




--- Comment #33 from hto <hto at dev.null>  2009-12-08 22:08:54 CET ---
> BTW I think this as a serious bug, hinders testing/debugging.

> /* First get the ImageBase of the File. If its smaller than the given
>  * Parameter, everything is ok, because it was already added onto the
>  * adress and can be given directly to process_file. If not, add it and
>  * give the result to process_file.
>  */

Here is the problem. Log2Lines tries to deal with both absolute and relative
(to image base) addresses. It (and raddr2line, too) falsely assumes that if
address > base, it is absolute. (Perhaps it would be safe (modulo relocation)
to say that if address > 0x400000, it is absolute.) Also, translate_file() adds
a base to an address, then fixup_offset() subtracts --- a complication.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.