[ros-bugs] [Bug 4342] log2lines: Enhanced raddr2line replacement

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=4342





--- Comment #34 from jansssens <jroeloffzen at hotmail.com>  2009-12-09 00:06:19 CET ---
(In reply to comment #33)
> > /* First get the ImageBase of the File. If its smaller than the given
> >  * Parameter, everything is ok, because it was already added onto the
> >  * adress and can be given directly to process_file. If not, add it and
> >  * give the result to process_file.
> >  */

> Here is the problem. Log2Lines tries to deal with both absolute and relative
> (to image base) addresses. It (and raddr2line, too) falsely assumes that if
> address > base, it is absolute. (Perhaps it would be safe (modulo relocation)
> to say that if address > 0x400000, it is absolute.) 
Would that also work for images larger than 0x400000 (4MB)?

> Also, translate_file() adds
> a base to an address, then fixup_offset() subtracts --- a complication.
Actually, the comment above and check are taken from raddr2line.cmd. They
should behave exactly the same in this respect. Remove this check and change
the comparison in fixup_offset to '>' would simplify things a bit (but not
change any behaviour).


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.