[ros-bugs] [Bug 3976] Multiple instances of Task Manager

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=3976


Colin Finck <mail at colinfinck.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Colin Finck <mail at colinfinck.de>  2009-02-04 00:55:54 CET ---
Modified patch committed in r39353.

I changed the patch a bit:
- Task-Manager was fully converted to Unicode some time ago, so nobody should
introduce TCHARs again here. Using WCHARs is the way to go here.

- Constants usually aren't placed in header files as it is possible that header
files have no include guards, so that they are used multiple times. Thus, the
constant could also be defined several times, which leads to building problems.
The right way would have been placing it in a source file and then referencing
it over "extern ..." in a header file (if it's even needed in more than one
source file).

- But as the constant was only used once, I finally didn't even define it as a
constant and just passed the value to CreateMutexW :-)

(In reply to comment #3)
> I dont think we should imitate Windows Server 2008 behavior at this point of
> development

XP's Task-Manager has the same behaviour.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.