[ros-bugs] [Bug 3400] size of file begins with zeros

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=3400


amine48rz <amine48rz at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|ros-bugs at reactos.org        |Christoph at ApiViewer.de
           Severity|normal                      |major

Christoph_vW <Christoph at ApiViewer.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

Lone_Rifle <alwyn.tan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alwyn.tan at gmail.com




--- Comment #5 from zooba <zooba at aanet.com.au>  2009-01-19 09:14:22 CET ---
Created an attachment (id=3440)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=3440)
Patch for this bug - not yet thoroughly tested

I can't see anything wrong with StrFormatByteSizeW. It appears that snprintfW
(via FormatDouble in lcformat.c) is adding leading zeros to the string - so 228
is passed to GetNumberFormat as "000228", hence the leading zeros.

Vista's GetNumberFormat trims leading zeros, so I expect we need the same
behaviour implemented for ReactOS? I've managed to patch GetNumberFormat so it
works, but haven't thoroughly tested my changes yet (patch attached).


--- Comment #6 from Christoph_vW <Christoph at ApiViewer.de>  2009-01-19 11:23:35 CET ---
committed in r38930


--- Comment #7 from Lone_Rifle <alwyn.tan at gmail.com>  2009-01-19 12:53:12 CET ---
(In reply to comment #6)
> committed in r38930
> 
For some absurd reason the commit breaks buildbot tests. Could be
intermittent.. 
http://www.reactos.org:8010/builders/ReactOS_%28Debug%29/builds/12959/steps/test/logs/stdio


--- Comment #8 from Lone_Rifle <alwyn.tan at gmail.com>  2009-01-19 12:58:43 CET ---
(In reply to comment #7)
> (In reply to comment #6)
> > committed in r38930
> > 
> For some absurd reason the commit breaks buildbot tests. Could be
> intermittent.. 
> http://www.reactos.org:8010/builders/ReactOS_%28Debug%29/builds/12959/steps/test/logs/stdio
> 

Ignore. Was indeed intermittent.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.