[ros-bugs] [Bug 4143] Fix for BitBlt, TransparentBlt, MaskBlt
ReactOS.Bugzilla at www.reactos.org
ReactOS.Bugzilla at www.reactos.org
Sun Mar 8 22:50:20 CET 2009
http://www.reactos.org/bugzilla/show_bug.cgi?id=4143
towerr <tower at reactos.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tower at reactos.org
Status|UNCONFIRMED |RESOLVED
Resolution| |INVALID
bolt <bstsoft at narod.ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |UNCONFIRMED
Resolution|INVALID |
jimtabor <jimtabor at adsl-64-217-116-74.dsl.hstntx.swbell.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jimtabor at adsl-64-217-116-
| |74.dsl.hstntx.swbell.net
grschneider <grschneider at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |grschneider at gmail.com
Severity|normal |major
Status|UNCONFIRMED |NEW
Ever Confirmed|0 |1
bolt <bstsoft at narod.ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3544 is|0 |1
obsolete| |
Attachment #3545 is|0 |1
obsolete| |
Lone_Rifle <alwyn.tan at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |alwyn.tan at gmail.com
q4a <q4a at bk.ru> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |q4a at bk.ru
--- Comment #3 from towerr <tower at reactos.org> 2009-02-08 03:32:11 CET ---
looks like a spam, yet even no ideas i have for thoses pictures, because the
problem isn't solved with applyed a patch, so guys look twice before commit a
patch which presented here :(
--- Comment #4 from towerr <tower at reactos.org> 2009-02-08 03:34:14 CET ---
looks like a spam, yet even no ideas i have for thoses pictures, because the
problem isn't solved with applyed a patch, so guys look twice before commit a
patch which presented here :(
--- Comment #5 from towerr <tower at reactos.org> 2009-02-08 04:12:02 CET ---
-WHF?! after this patch:
*** Fatal System Error: 0x0000001e
(0xC0000094,0x9F95AC14,0x9EED0740,0x00000000)
Entered debugger on embedded INT3 at 0x0008:0x808c1388.
kdb:> bt
Eip:
<NTOSKRNL.EXE:c1389 (lib\rtl\i386\debug_asm.S:42
(RtlpBreakWithStatusInstruction))>
Frames:
<NTOSKRNL.EXE:65fd (ntoskrnl/ke/bug.c:1089 (KeBugCheckWithTf at 24))>
<NTOSKRNL.EXE:68a9 (ntoskrnl/ke/bug.c:1400 (KeBugCheck at 4))>
<NTOSKRNL.EXE:2e21 (ntoskrnl/ke/i386/exp.c:1011 (_SEHExcept.34419))>
<NTOSKRNL.EXE:ba35c (ntoskrnl\ke\i386\trap.s:638 (CommonDispatchException))>
<win32k.sys:87c14 (subsystems/win32/win32k/objects/bitblt.c:889
(NtGdiStretchBlt at 48))>
<NTOSKRNL.EXE:b9a6c (ntoskrnl\ke\i386\trap.s:244 (KiFastCallEntry))>
looooook:
(subsystems/win32/win32k/objects/bitblt.c:889 (NtGdiStretchBlt at 48))
--- Comment #6 from bolt <bstsoft at narod.ru> 2009-02-08 06:44:04 CET ---
(In reply to comment #5)
> -WHF?! after this patch:
> *** Fatal System Error: 0x0000001e
> (0xC0000094,0x9F95AC14,0x9EED0740,0x00000000)
> Entered debugger on embedded INT3 at 0x0008:0x808c1388.
> kdb:> bt
> Eip:
> <NTOSKRNL.EXE:c1389 (lib\rtl\i386\debug_asm.S:42
> (RtlpBreakWithStatusInstruction))>
> Frames:
> <NTOSKRNL.EXE:65fd (ntoskrnl/ke/bug.c:1089 (KeBugCheckWithTf at 24))>
> <NTOSKRNL.EXE:68a9 (ntoskrnl/ke/bug.c:1400 (KeBugCheck at 4))>
> <NTOSKRNL.EXE:2e21 (ntoskrnl/ke/i386/exp.c:1011 (_SEHExcept.34419))>
> <NTOSKRNL.EXE:ba35c (ntoskrnl\ke\i386\trap.s:638 (CommonDispatchException))>
> <win32k.sys:87c14 (subsystems/win32/win32k/objects/bitblt.c:889
> (NtGdiStretchBlt at 48))>
> <NTOSKRNL.EXE:b9a6c (ntoskrnl\ke\i386\trap.s:244 (KiFastCallEntry))>
> looooook:
> (subsystems/win32/win32k/objects/bitblt.c:889 (NtGdiStretchBlt at 48))
In the code did not have change for NtGdiStretchBlt.
--- Comment #7 from jimtabor <jimtabor at adsl-64-217-116-74.dsl.hstntx.swbell.net> 2009-02-08 09:58:28 CET ---
Hi,
Are there any other patches needed to help with this one? If so please add them
to this bug report. ATM I'm out of time.
Thanks,
James
--- Comment #8 from grschneider <grschneider at gmail.com> 2009-02-08 12:21:37 CET ---
Seems I commited part of this patch independently, the TransparentBlt
conversion is already in (r39480).
BitBlt coord transformation should be ok too, so I'll have a look at those
MaskBlt changes.
--- Comment #9 from grschneider <grschneider at gmail.com> 2009-02-08 17:25:34 CET ---
BitBlt source coordinate fix was commited in r39485.
My comments on the maskblt code:
Point 1: it's old wine code and should probably be updated.
Point 2: variables first, code afterwards.
Point 3: no autoenabled debug prints, that's considered spam.
--- Comment #10 from bolt <bstsoft at narod.ru> 2009-02-08 17:52:21 CET ---
(In reply to comment #9)
> BitBlt source coordinate fix was commited in r39485.
> My comments on the maskblt code:
> Point 1: it's old wine code and should probably be updated.
> Point 2: variables first, code afterwards.
> Point 3: no autoenabled debug prints, that's considered spam.
1.Code which propose is 5 years worked without any problems. I ask to accept.
2.Sorry.
3.Sorry.
--- Comment #11 from bolt <bstsoft at narod.ru> 2009-03-05 16:06:45 CET ---
Created an attachment (id=3652)
--> (http://www.reactos.org/bugzilla/attachment.cgi?id=3652)
Patch file
Last fix NtGdiMaskBlt
see http://www.reactos.org/bugzilla/attachment.cgi?id=3546
test execute program
http://www.sayan.ru/~bolt/ReactOS/bug_pos/Project1.zip
--- Comment #12 from Lone_Rifle <alwyn.tan at gmail.com> 2009-03-05 18:40:44 CET ---
(In reply to comment #11)
> Created an attachment (id=3652)
--> (http://www.reactos.org/bugzilla/attachment.cgi?id=3652) [details]
> Patch file
>
> Last fix NtGdiMaskBlt
>
> see http://www.reactos.org/bugzilla/attachment.cgi?id=3546
>
> test execute program
> http://www.sayan.ru/~bolt/ReactOS/bug_pos/Project1.zip
>
Just a future note, you could just say attachment 3546 , instead of pasting the
link.. it's a matter of style; using complete URLs will make the attachments
directly accessible from the ros-bugs mailing list.
--
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the Ros-bugs
mailing list