[ros-bugs] [Bug 4420] About DPRINT() / DPRINT1() macros

[ReactOS.Bugzilla at www.reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=4420





--- Comment #1 from aspotashev <aspotashev at gmail.com>  2009-05-17 18:59:34 CET ---
(In reply to comment #0)
> Created an attachment (id=3873)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=3873) [details]
> Patch
> 
> The DPRINT() / DPRINT1() macros call DbgPrint() twice. Sometimes it causes
> slowdowns, sometimes the tho parts of a line become disjoined.

But there's also a disadvantage, look at the following code:
    ULONG *ptr;

    ptr = ...; /* initialize 'ptr' with something... */
    DPRINT1("*ptr = 0x%08x\n", *ptr);

If accessing '*ptr' produces an exception, with your patch DPRINT1 will do
nothing (our thread crashes before writing to the debug log). But without the
patch you will see the file name and the line number of the appropriate DPRINT1
call, that might be very useful information.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.