[ros-bugs] [Bug 4934] rapps can't install any app (hangs)

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=4934





--- Comment #20 from Ged <gedmurphy at reactos.org>  2009-11-06 11:22:43 CET ---
> Next time, could You please try to give a motivation
> before You cut someone down by the kneecaps ?

That wasn't my intention and I appologise if you took it in that manner.
Terming things as 'a bit hackish' is a term regularly thrown around in
programming and isn't meant to be offensive. You'll regularly see our devs
putting code into reactos with a comment /* This is a hack */ or whatever. 
It's not that the code itself is bad, it's just that it's a temperary solution
to fix a bigger problem.

> > Firstly, if an installer hangs it's not the fault of rapps,
> > there is probably an underlying issue.
> Precisely, it's not the fault of rapps, so why should it be the one
> to take the fall (i.e suffer an external hang) ?

This is the underlying problem in this case. rapps is flawed in its design in
this area. It really shouldn't be waiting for installers, it's pretty much an
impossible task. If it were possible to reliably wait for installers then you
would expect Microsoft to do the same, even raise an event or issue a callback.
The nature of win32 installers is that it isn't that simple. Thus, the problem
isn't your code, it's what your patch is trying to do.
IMO rapps should start up the installer and move on. It's the only reliable
thing to do.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.