[ros-bugs] [Bug 4862] Implement dxg.sys DxDdEnableDirectDraw

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=4862


jimtabor <jimtabor at adsl-64-217-116-74.dsl.hstntx.swbell.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |timo.kreuzer at web.de




--- Comment #9 from jimtabor <jimtabor at adsl-64-217-116-74.dsl.hstntx.swbell.net>  2009-09-27 20:09:31 CET ---
Hi,
EDD_DIRECTDRAW_GLOBAL is in:
include/reactos/drivers/directx/directxint.h

Your patch, I guess I'm not teaching it correctly.

pDev = pDC->ppdev;

then,,,

+    if  ( ( pDev->DevEdd.DriverFunctions.DisableDirectDraw == NULL) ||

pDev->DevEdd. <--- this is not what I meant, it should stay the orig way: 
if  ( ( pDev->DriverFunctions.DisableDirectDraw == NULL) ||

DevEdd should be setup in all the DDx code not anywhere else...

PDEVEDD container is expanded in the DDx code based on the pPDevObj that is
passed to the DDx code.

The best method I can see is this,,
PEDD_DIRECTDRAW_GLOBAL pEDDgpl;
PPDEVEDD ppdevedd = (PPDEVEDD)ppdevobj;
pEDDgpl = (PEDD_DIRECTDRAW_GLOBAL)ppdevedd->EDDgpl; // Get pointer to EDDgpl.

This will minimize the changes needed in the main code tree, leaving the bulk
changes in win32k/ntddraw and drivers/directx. Technically, I guess, stay out
of win32k/objects and work in win32k/ntddraw and drivers/directx. You still
need to touch base with Timo Kreuzer (Physicus).

Thanks,
James


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.