[ros-bugs] [Bug 2320] Clock does not show completely

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=2320





--- Comment #8 from Ged <gedmurphy at reactos.org>  2010-05-10 10:26:37 CET ---
(In reply to comment #7)

> The patch is wrong, the problem hidden somewhere else? Come on!

I'm not really sure why you feel the need to try and belittle me??
Anyway, I'll discuss the patch from the way I saw it.

> 1. No. This function creates a window and does not draw anything
> (DT_CALCRECT...). "23:20 PM" takes more space then "1:20 PM". Using an
> arbitrary systemtime there is a good way to get around this problem.

What's the reason to pass in time information if it's always going to return 5
chars in the format '00:00' ?

> 2. No. Count yourself: "23:20 PM\0", this time takes more than 8 chars.

Where are you getting ' PM' from?
AFAIK, GetTimeFormat will only return "00:00" which needs 6 chars

> 3. This change was done to keep window creation and drawing consistent, the
> provided patch even shows the two inconsistencies.

In which case the incorrect usage should have been corrected instead of making
the correct one incorrect.


I've quickly looked at this patch again and I don't see an obvious fix. The
only inconsistency I can see is that in the Create method the buffer has a size
of 8 instead of 16 as used in the _time member, but as GetTimeFormat only ever
uses 6 chars I don't see a problem.

Maybe I'm missing something glaringly obvious, I'd be happy if you could point
it out.

Ged.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.