[ros-bugs] [Bug 5948] PATCH: ListView search on keypress loops endlessly (huge "SidInToken Calls" numbers)

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=5948





--- Comment #1 from ThFabba <thfabba at gmx.de>  2011-02-23 10:13:12 CET ---
Created an attachment (id=5824)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=5824)
Fix for the issue

The problem lies in LISTVIEW_ProcessLetterKeys. There is a while (1) loop
starting in dll\win32\comctl32\listview.c:1827 which is supposed to be run at
most twice.
In the event that no item is selected, "startidx" will have the value 0,
"endidx" will be infoPtr->nItemCount. This case will trigger neither the first
(line 1830) nor the later (line 1859) exit condition if no item is found.

The attached patch remedies this problem (albeit in a very simple manner ;]).


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.