[ros-bugs] [Bug 5827] New: REGRESSION: PATCH: user32:cursoricon has regressed

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=5827

           Summary: REGRESSION: PATCH: user32:cursoricon has regressed
           Product: ReactOS
           Version: TRUNK
          Platform: x86 Hardware
        OS/Version: ReactOS
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: Win32
        AssignedTo: ros-bugs at reactos.org
        ReportedBy: vicmarcal at hotmail.com


R50363->582 tested/36 failed
R50367->582 tested/37 failed

GUILTY REVISION: 50365 (67 is related to explorer-new and 66 is a branch
commit)

[WIN32K]
- In UserSetCursor, return a pointer to the old cursor, not the handle
- really delete the pointer shape when NULL cursor is set, instead of just hiding it.
- Move reference handling completely to NtUserSetCursor
- In UserChangeDisplaySettings, set NULL cursor before change and restore old cursor after change to make sure we have the right color format.

See issue #5722 for more details.
*****************

The test failed is: cursoricon.c 1501
Winetest sets an invalid handle and we dont return ERROR_INVALID_CURSOR_HANDLE
******************
The trivial patch:
Line 872 
http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ntuser/cursoricon.c?revision=50375&view=markup

-            EngSetLastError(ERROR_INVALID_HANDLE);
+           EngSetLastError(ERROR_INVALID_CURSOR_HANDLE);


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.