[ros-bugs] [Bug 6150] WIP: explorer-new: command line arguments

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=6150


grschneider <grschneider at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |grschneider at gmail.com
            Summary|PATCH: explorer-new: command|WIP: explorer-new: command
                   |line arguments              |line arguments




--- Comment #3 from grschneider <grschneider at gmail.com>  2011-05-06 17:13:55 CET ---
Looking at the patch I have the following suggestions:
-Don't print to stderr, explorer usually won't have a terminal windows
associated with it. Should be changed to some kind of debug print if really
necessary.
-Don't add resources to code files and mark them with FIXME. Add them to the
resource files
-What is getappname good for?
-What is GetMultiByteString good for? It isn't used...
-What are the commented out codes good for?
-Formatting is broken (tabs vs. spaces)
-You start defining exit constants, but use numerals (see exit(4);) -
consistency!
-Consider using getopt, so you don't implement command line parsing yourself
completely
-GUIDs should be placed in a common header files


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.