[ros-bugs] [Bug 4423] win32k: image corruption and crash in DIB_ColorFill() while using Firefox

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=4423





--- Comment #9 from IgorS <4seev3 at gmail.com>  2011-10-14 11:08:14 CET ---
Created an attachment (id=6849)
 --> (http://www.reactos.org/bugzilla/attachment.cgi?id=6849)
Possible fix

This patch fixes a copy-paste error in EngBitBlt() and also improves
DIB_32BPP_ColorFill() behaviour in case when input rectangle is invalid (RECTL
structure fields are signed, so "jle" instruction should be used instead of
"jbe").

Note that "EngBitBlt is never called with an empty destination rectangle. The
two points that define the rectangle are always well ordered.", according to
MSDN.
(http://msdn.microsoft.com/en-us/library/windows/hardware/ff564185%28v=vs.85%29.aspx)
This means that "RECTL_vMakeWellOrdered(&OutputRect);" line may be removed at
all, as well as "RECTL_vMakeWellOrdered(&rclClipped)" in IntEngBitBlt().


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.