[ros-bugs] [Bug 5281] PATCH: Ctrl+C on MessageBox

ReactOS.Bugzilla at reactos.org ReactOS.Bugzilla at reactos.org
Thu Apr 26 14:34:22 UTC 2012


http://www.reactos.org/bugzilla/show_bug.cgi?id=5281


ThePhysicist <timo.kreuzer at web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #11 from ThePhysicist <timo.kreuzer at web.de>  2012-04-26 14:34:21 CET ---
The patch is ok, I would just suggest one small improvement:
It currently allocates 2 string buffers, but it could as well allocate one 
buffer covering both strings
and set the 2nd pointer pointing after the first string.

pszTitle = RtlAllocateHeap(GetProcessHeap(), 0, (cchTitle + cchText) * 
sizeof(WCHAR));
...
pszText = pszTitle + cchTitle;

And please let us know your real name for the commit message.
Thanks.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the Ros-bugs mailing list