[ros-bugs] [Bug 7021] dxdiag: msvc build fix

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=7021


ThFabba <thfabba at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thfabba at gmx.de
              Alias|FIX                         |




--- Comment #1 from ThFabba <thfabba at gmx.de>  2012-04-26 16:17:46 CET ---
Hi,

thanks for your patch.

First some notes about the code:
- Try to keep consistent formatting (spaces in CMake files, either indent code
with spaces or tabs, not both)
- GCC defines __GNUC__, not GCC
- LoadLibrary takes a reference to a module. Doing this on every call is a bad
idea. Also, it must be cleaned up by a FreeLibrary call later
- You cannot return GetProcAddress's return value directly, and shouldn't use
it to directly call the function. Use a correctly typed function pointer
instead

The real issue, though, is that ddraw and d3d9 are set not to be built with
MSVC. Aside from some minor issues, they seem to build fine, though. I'll
enable build for them, which should fix dxdiag as well.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.