[ros-bugs] [Bug 6771] ReactOS setup fails if there is space in destination dir

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=6771


Bblaauw <bblaauw at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bblaauw at gmail.com




--- Comment #3 from Bblaauw <bblaauw at gmail.com>  2012-01-10 18:48:14 CET ---
(In reply to comment #2)
> After spending some time there is what I have found out:
> ReactOS fails to start because text after space is treated as command line
> arguments (base\system\smss\smapiexec.c line 227). Quoting here will not solve
> the problem, because Data (line 223) comes from registry (lib\smlib\lookupss.c
> line 32).

* 8.3 naming scheme seems to work (no delimiter present by default)
* LFN without delimiter seems to work (\REACTOS123456789)
* LFN with space as delimiter seems to fail per your bugreport
* Does LFN with other signs as delimiter work?
* Does a dir-path work? 
* Does a drive work? Does ReactOS add ":\REACTOS" or "\REACTOS"

Possible input to test against:
- \
- \REACTOS
- \REACTOS\
- \REACTOS123456789
- C:\REACTOS
- C:\REACTOS\
- C:REACTOS
- C:\REACTOS\
- C (is this a drive or dir-name?)
- C:
- C:\
- \PARENTDIR\CHILDDIR (where parent dir already exists)
- \PARENTDIR\CHILDDIR (where parent dir also has to be created)
- \PARENT DIR\CHILD DIR (where parent dir already exists)
- \PARENT DIR\CHILD DIR (where parent dir also has to be created)
- \PARENTDIR\CHILD DIR (where parent dir already exists)
- \PARENTDIR\CHILD DIR (where parent dir also has to be created)
- \PARENT DIR\CHILDDIR (where parent dir already exists)
- \PARENT DIR\CHILDDIR (where parent dir also has to be created)

Invalid input anyway:
* anything with "*" or "/" or whatever isn't allowed.
* invalid drives/devices (non-existing or before C: )
* DOS-devices? C:\NUL , C:\CON\CON (hi Win98 BSOD)
* C\

If this should be filed as 2 separate bugs instead ( 1 for spaces, other one
for path-building/checking) at the same code spot, let me know.
Your bug seems to cause issues only in phase 2? Thus finishing phase 1
succesfully? Or already issues during filecopy in BootCD phase?


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.