[ros-bugs] [Bug 4377] notepad: Find command doesn't work right.

[ReactOS.Bugzilla at reactos.org]

http://www.reactos.org/bugzilla/show_bug.cgi?id=4377


CodeVisio <codevisio at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |codevisio at gmail.com




--- Comment #7 from CodeVisio <codevisio at gmail.com>  2012-03-06 23:16:00 CET ---
Hi,

Carlo is partially right.

The problem is inside that function, and has as side effect the bug #4377.
The clear flags is right, but it's shouldn't clear al FR_* flags.
In particular it should clear only events flags, that is flags raised but
the interaction of the user with the modeless FindText dialog.
The other flags, whole word, up, down etc., shouldn't be clear because they
represent the 'state' of the user choice e not events raised to the dialog
owner. In this way the flag structure FINDREPLACE the user had supplied to the
call are consistent with user choices.

There still are other bugs related to this part of the code, for example if you
click on the Up radio button to perform a 'backward' search it won't work.

I saw a little code about comdlg32, but from my personal opinion that code
should heavily reviewed.


-- 
Configure bugmail: http://www.reactos.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.