[ros-dev] Re: [ros-cvs] CVS Update: reactos

[Hartmut Birr]

> -----Original Message-----
> From: ros-dev-bounces at reactos.com 
> [mailto:ros-dev-bounces at reactos.com] On Behalf Of Alex Ionescu
> Sent: Sunday, October 17, 2004 2:51 PM
> To: ros-dev at reactos.com; hbirr at osexperts.com
> Subject: [ros-dev] Re: [ros-cvs] CVS Update: reactos
> 
> 
> >
> >Modified files:
> >	reactos/ntoskrnl/include/internal/i386/: ps.h 
> >
> >Log message:
> >	- Fixed the definition KPCR_SELF and KeGetCurrentKPCR.
> >
> Is that really right? I can swear fs:18h was still used until NT 5.2.

I think that is correct. Previous your last changes the offset to KPCR->Self
was 0x18. After your changes the offset is 0x1c. The offset 0x18 does point
to KPCR->Tib.Self. Win2K and WinXP (UP version) doesn't use the value at
offset 0x18. This value is always 0. 

> Also, it would be of critical importance to:
>     1) Change the hardcoded offsets to FIELD_OFFSET(...,...)

The assembler doesn't like the C definition for FIELD_OFFSET.

>     2) Make the ASM use the defines instead of hardcoding 1Ch/18h

The inline assembler doesn't like the definition for KPCR_SELF. The
assembler interprets KPCR_SELF as symbol at this point.

I've changed KPCR_SELF from 0x18 to 0x1c, because ros asserts in main.c line
#309.

- Hartmut